feast icon indicating copy to clipboard operation
feast copied to clipboard

Published 20 hours ago • verified publisher icon feast-dev

fix: Handle ComplexFeastType to None comparison

Open jahstreet opened this issue 1 year ago • 2 comments

What this PR does / why we need it:

We need this fix to avoid additional None checks when comparing ComplexFeastType instances on equality. It also aligns the __eq__ implementation with PrimitiveFeastType below.

Which issue(s) this PR fixes:

N/A

jahstreet avatar Jan 05 '24 12:01 jahstreet

This PR failed the integration tests. Can you please take a look @jahstreet ?

etirelli avatar Jan 15 '24 20:01 etirelli

@jahstreet just following on this PR

Let's know if you need any help to fix the integration tests to merge this PR thanks

redhatHameed avatar Jan 30 '24 15:01 redhatHameed