feast icon indicating copy to clipboard operation
feast copied to clipboard

feat: Added delete_table to redis online store

Open phil-park opened this issue 1 year ago • 4 comments

What this PR does / why we need it:

Even if the feature view is no longer used, the data is not deleted until there are no feature views left in the join key.

Memory in redis is a very expensive resource.

When deleting feature_view, a function is added so that the corresponding key can be found and deleted in the redis hash.

Which issue(s) this PR fixes:

Fixes #3856

phil-park avatar Dec 05 '23 11:12 phil-park

@etirelli The code looks good to me, but I would like another pair of eyes to take a look at this PR.

redhatHameed avatar Jan 17 '24 21:01 redhatHameed

great idea but is it not a good practice to conduct scanning on production redis database?

sudohainguyen avatar Jan 21 '24 03:01 sudohainguyen

@phil-park thank you for your PR. Unfortunately we have an integration test failure, can you please take a look?

@sudohainguyen while scanning Redis tables is not a best practice, the existing code already scans the db . Since a change to this will probably require considerable changes, I would like to do so under a different ticket/PR.

etirelli avatar Jan 24 '24 20:01 etirelli

@etirelli There were some issues with my commit and I resolved those issues.Please check. thank you!

phil-park avatar Feb 11 '24 13:02 phil-park