feat: Custom schema for SQL Registry

[zerafachris]

What this PR does / why we need it: Current SQL Registry uses public schema. This provides a registry_schema inside of config_yaml that will use registry_schema for all registry related tables.

Which issue(s) this PR fixes: https://github.com/feast-dev/feast/issues/3568

Fixes #3568

[adamschmidt]

Have you considered using the db_schema property that's in the pgsql connection config properties? This same configuration class is used for the online store, so this should work too.

Adding a specific schema name seems redundant if you use this.

[zerafachris]

Hi @adamschmidt , the feature handles the metadata object inside of PostGres. I can use db_schema instead of registry_schema no worries, however the class model is not being used. All objects that are supplied in the config are parsed independently.

[zerafachris]

@adchia could you kindly have a look

[adchia]

Assigning to @achals since he's more familiar with this code!

[feast-ci-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zerafachris To complete the pull request process, please assign achals after the PR has been reviewed. You can assign the PR to them by writing /assign @achals in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[zerafachris]

/assign @achals

[zerafachris]

Conflicts have been resolved. Can we get a review

[feast-ci-bot]

@zerafachris: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[zerafachris]

/lint

[zerafachris]

Hi @achals , do you think we can get a peer review? I do not wish to stay resyncing with master branch and resolve conflicts again.

[jeremyary]

Hi @zerafachris, with new maintainers in place we're making best efforts to try and resolve long-standing conversations such as what you've encountered here. With that in mind, we'd still have a few things to work through prior to merging your contribution. As a start, our DCO check indicates here some fixes that are needed. If you're still interested in persuing the PR, please take a look at this & other running checks. Thanks!