What this PR does / why we need it: This updates the feast ui command to create the ui/build/ folder if it does not exist. Without this, the feast ui will fail.

Which issue(s) this PR fixes:

Fixes #

Sep 23 '22 02:09 franciscojavierarceo

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: franciscojavierarceo To complete the pull request process, please assign tsotnet after the PR has been reviewed. You can assign the PR to them by writing /assign @tsotnet in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

Sep 23 '22 02:09 feast-ci-bot

have you tested this locally?

if there's no directory that means the built ui resources don't exist so it wouldn't be able to mount the html / css / js etc files.

if there is one, then there should be bundled resources. i think then this shouldn't be needed. if you're missing the directory it must be some broken build of feast or something

Sep 23 '22 02:09 adchia

Codecov Report

Base: 67.50% // Head: 58.14% // Decreases project coverage by -9.36% :warning:

Coverage data is based on head (d42764f) compared to base (b48d36b). Patch coverage: 25.00% of modified lines in pull request are covered.

:exclamation: Current head d42764f differs from pull request most recent head d0d8e47. Consider uploading reports for the commit d0d8e47 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3245      +/-   ##
==========================================
- Coverage   67.50%   58.14%   -9.37%     
==========================================
  Files         179      213      +34     
  Lines       16371    17818    +1447     
==========================================
- Hits        11051    10360     -691     
- Misses       5320     7458    +2138

Flag	Coverage Δ
integrationtests	`?`
unittests	`58.14% <25.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
sdk/python/feast/ui_server.py	`24.00% <25.00%> (+0.08%)`	:arrow_up:
...sts/integration/registration/test_universal_cli.py	`20.20% <0.00%> (-79.80%)`	:arrow_down:
...ts/integration/offline_store/test_offline_write.py	`26.08% <0.00%> (-73.92%)`	:arrow_down:
...fline_store/test_universal_historical_retrieval.py	`28.75% <0.00%> (-71.25%)`	:arrow_down:
...ests/integration/e2e/test_python_feature_server.py	`29.50% <0.00%> (-70.50%)`	:arrow_down:
...dk/python/tests/integration/e2e/test_validation.py	`27.55% <0.00%> (-69.30%)`	:arrow_down:
...s/integration/registration/test_universal_types.py	`32.25% <0.00%> (-67.75%)`	:arrow_down:
sdk/python/feast/infra/online_stores/redis.py	`28.39% <0.00%> (-66.67%)`	:arrow_down:
sdk/python/tests/integration/e2e/test_usage_e2e.py	`33.87% <0.00%> (-66.13%)`	:arrow_down:
sdk/python/tests/data/data_creator.py	`34.78% <0.00%> (-65.22%)`	:arrow_down:
... and 167 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Sep 23 '22 02:09 codecov-commenter

I locally verified with Feast 0.25 on a fresh install that the feast ui command works? Closing this, but feel free to re-open if you have more details!

Sep 26 '22 14:09 adchia

fix: Updated ui_dir server call to make the directory if missing

Codecov Report