feast icon indicating copy to clipboard operation
feast copied to clipboard

chore: Add other maintainers to the OWNERS file for /lgtm commands

Open achals opened this issue 3 years ago • 2 comments

Signed-off-by: Achal Shah [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

achals avatar Sep 22 '22 17:09 achals

/verify-owners

adchia avatar Sep 26 '22 14:09 adchia

Codecov Report

Base: 67.50% // Head: 58.16% // Decreases project coverage by -9.33% :warning:

Coverage data is based on head (2cfc1e7) compared to base (a2dc0d0). Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3243      +/-   ##
==========================================
- Coverage   67.50%   58.16%   -9.34%     
==========================================
  Files         179      213      +34     
  Lines       16371    17825    +1454     
==========================================
- Hits        11051    10368     -683     
- Misses       5320     7457    +2137     
Flag Coverage Δ
integrationtests ?
unittests 58.16% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sts/integration/registration/test_universal_cli.py 20.20% <0.00%> (-79.80%) :arrow_down:
...ts/integration/offline_store/test_offline_write.py 26.08% <0.00%> (-73.92%) :arrow_down:
...fline_store/test_universal_historical_retrieval.py 28.75% <0.00%> (-71.25%) :arrow_down:
...ests/integration/e2e/test_python_feature_server.py 29.50% <0.00%> (-70.50%) :arrow_down:
...dk/python/tests/integration/e2e/test_validation.py 27.55% <0.00%> (-69.30%) :arrow_down:
...s/integration/registration/test_universal_types.py 32.25% <0.00%> (-67.75%) :arrow_down:
sdk/python/feast/infra/online_stores/redis.py 28.39% <0.00%> (-66.67%) :arrow_down:
sdk/python/tests/integration/e2e/test_usage_e2e.py 33.87% <0.00%> (-66.13%) :arrow_down:
sdk/python/tests/data/data_creator.py 34.78% <0.00%> (-65.22%) :arrow_down:
...n/tests/integration/registration/test_inference.py 35.71% <0.00%> (-64.29%) :arrow_down:
... and 167 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Sep 26 '22 15:09 codecov-commenter

/verify-owners

adchia avatar Sep 26 '22 15:09 adchia

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

feast-ci-bot avatar Sep 26 '22 15:09 feast-ci-bot