fix: Fix numpy version specification

[acmarco]

What this PR does / why we need it:

The install script for version 0.22 creates conflicts with other packages over the version of numpy. It looks like the version specification is wrong as it is unusual to see redundant constraints like what is there now (i.e: <1.22 and also <2).

Which issue(s) this PR fixes:

Fixes #

[achals]

🤦🏽 Thanks for the catch @acmarco . Do you mind signing your commit?

[codecov-commenter]

Codecov Report

Base: 58.21% // Head: 58.21% // No change to project coverage :thumbsup:

Coverage data is based on head (92f2c06) compared to base (99e5d25). Patch has no changes to coverable lines.

Additional details and impacted files

@@              Coverage Diff              @@
##           v0.22-branch    #3241   +/-   ##
=============================================
  Coverage         58.21%   58.21%           
=============================================
  Files               177      177           
  Lines             15775    15775           
=============================================
  Hits               9183     9183           
  Misses             6592     6592           

Flag	Coverage Δ
unittests	58.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
setup.py	0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

[acmarco]

🤦🏽 Thanks for the catch @acmarco . Do you mind signing your commit?

My commit is signed (i.e: "This commit was signed with the committer’s verified signature. ") ... but maybe you mean another type of signature? Sorry if I am misunderstanding, @achals

[felixwang9817]

hey @acmarco, thanks for the PR! here's what we mean by signing your commits

also, is there a particular reason you're using Feast 0.22 instead of Feast 0.24?

[acmarco]

hey @acmarco, thanks for the PR! here's what we mean by signing your commits

also, is there a particular reason you're using Feast 0.22 instead of Feast 0.24?

Ah! OK. Sorry for the confusion. signed off.

The reason we are stuck on 0.22 is not Feast related, but that we install feast in same python env as other packages that require older versions of numpy and pandas. Upgrading other packages or re-jigging our envs would unblock upgrading Feast, but is a bit complicated right now. Definitely on our roadmap to upgrade Feast and the other packages we use.

[felixwang9817]

@acmarco got it, that makes sense. I'll approve this PR and cut a patch release (0.22.5) once it's in!

[feast-ci-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acmarco, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [felixwang9817]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[acmarco]

I'll approve this PR and cut a patch release (0.22.5) once it's in!

thanks for taking the time to address this PR. I was just wondering when the 0.22.5 patch might become available. thanks!

[adchia]

Let me cherrypick this right now and release!

[adchia]

Actually this PR doesn't make sense for specifically 0.22. We dropped Python 3.7 support in 0.23 (numpy 1.22 also drops this), so this results in a failed release.

[acmarco]

Actually this PR doesn't make sense for specifically 0.22. We dropped Python 3.7 support in 0.23 (numpy 1.22 also drops this), so this results in a failed release.

Sorry, i don't follow, but I just want to confirm that a it will not be possible to publish a 0.22.5 patch release with the changes from this PR. If not, is there any easy way to remedy that on my end? If there is no way, I'll consider this matter closed.

thanks

[adchia]

Yeah it will not be feasible. It's feasible to cherry-pick this into any minor release afterwards (i.e. 0.23+)