feast
feast copied to clipboard
feat: Add possibility to define feature_store.yaml path with env variable
Signed-off-by: arcabucero [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
/assign @woop
Codecov Report
Base: 67.48% // Head: 58.18% // Decreases project coverage by -9.30%
:warning:
Coverage data is based on head (
5c3a6a0
) compared to base (e117082
). Patch coverage: 85.71% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## master #3231 +/- ##
==========================================
- Coverage 67.48% 58.18% -9.31%
==========================================
Files 179 213 +34
Lines 16370 17845 +1475
==========================================
- Hits 11048 10383 -665
- Misses 5322 7462 +2140
Flag | Coverage Δ | |
---|---|---|
integrationtests | ? |
|
unittests | 58.18% <85.71%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
sdk/python/feast/cli.py | 38.77% <ø> (ø) |
|
sdk/python/feast/feature_store.py | 67.68% <ø> (-14.33%) |
:arrow_down: |
sdk/python/feast/infra/aws.py | 22.01% <50.00%> (-3.94%) |
:arrow_down: |
sdk/python/feast/utils.py | 85.43% <75.00%> (-7.20%) |
:arrow_down: |
sdk/python/feast/constants.py | 100.00% <100.00%> (ø) |
|
sdk/python/tests/unit/cli/test_cli.py | 100.00% <100.00%> (+80.30%) |
:arrow_up: |
...sts/integration/registration/test_universal_cli.py | 20.20% <0.00%> (-79.80%) |
:arrow_down: |
...ts/integration/offline_store/test_offline_write.py | 26.08% <0.00%> (-73.92%) |
:arrow_down: |
...fline_store/test_universal_historical_retrieval.py | 28.75% <0.00%> (-71.25%) |
:arrow_down: |
...ests/integration/e2e/test_python_feature_server.py | 29.50% <0.00%> (-70.50%) |
:arrow_down: |
... and 173 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: arcabucero, felixwang9817
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [felixwang9817]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment