feast icon indicating copy to clipboard operation
feast copied to clipboard

fix: Return 422 on bad push source name

Open robhowley opened this issue 3 years ago • 5 comments

Signed-off-by: Rob Howley [email protected]

What this PR does / why we need it:

  • added a new exception for push source not found
  • in the feature store, raise the PushSourceNotFoundException when a push source name is provided that doesn't exist
  • in feature server /push endpoint, return 422 in the case of a push source not found

Which issue(s) this PR fixes:

Fixes #3210

robhowley avatar Sep 15 '22 01:09 robhowley

Codecov Report

Base: 67.31% // Head: 58.16% // Decreases project coverage by -9.15% :warning:

Coverage data is based on head (5ef4216) compared to base (59b4853). Patch coverage: 40.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3214      +/-   ##
==========================================
- Coverage   67.31%   58.16%   -9.16%     
==========================================
  Files         179      213      +34     
  Lines       16276    17862    +1586     
==========================================
- Hits        10956    10389     -567     
- Misses       5320     7473    +2153     
Flag Coverage Δ
integrationtests ?
unittests 58.16% <40.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/feature_store.py 67.50% <0.00%> (-14.50%) :arrow_down:
sdk/python/feast/feature_server.py 31.32% <25.00%> (-39.57%) :arrow_down:
...ests/integration/e2e/test_python_feature_server.py 31.34% <50.00%> (-68.66%) :arrow_down:
sdk/python/feast/errors.py 68.08% <66.66%> (-0.03%) :arrow_down:
...sts/integration/registration/test_universal_cli.py 20.20% <0.00%> (-79.80%) :arrow_down:
...ts/integration/offline_store/test_offline_write.py 26.08% <0.00%> (-73.92%) :arrow_down:
...fline_store/test_universal_historical_retrieval.py 28.75% <0.00%> (-71.25%) :arrow_down:
...dk/python/tests/integration/e2e/test_validation.py 27.55% <0.00%> (-69.30%) :arrow_down:
...s/integration/registration/test_universal_types.py 32.25% <0.00%> (-67.75%) :arrow_down:
... and 176 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Sep 15 '22 01:09 codecov-commenter

im a little confused. i signed the commits and DCO check agreed. not sure what block is referring to when it says, "Merging is blocked. The base branch requires all commits to be signed."

robhowley avatar Sep 15 '22 19:09 robhowley

Yeah that's just a red herring. Your pushed changes removed the "lgtm" tag so it couldn't merge

adchia avatar Sep 15 '22 20:09 adchia

converted to draft while i fix the integration test

robhowley avatar Sep 15 '22 20:09 robhowley

hey @adchia, i finally got around to fixing the integration test. looks like everything passed. thanks for your patience.

robhowley avatar Sep 28 '22 21:09 robhowley

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, robhowley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

feast-ci-bot avatar Sep 29 '22 00:09 feast-ci-bot