feast icon indicating copy to clipboard operation
feast copied to clipboard

fix: Enable users to upgrade a batch source into a push source

Open adchia opened this issue 2 years ago • 5 comments

Signed-off-by: Danny Chiao [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes # https://github.com/feast-dev/feast/issues/3207

adchia avatar Sep 14 '22 16:09 adchia

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

feast-ci-bot avatar Sep 14 '22 16:09 feast-ci-bot

Codecov Report

Base: 67.03% // Head: 58.30% // Decreases project coverage by -8.73% :warning:

Coverage data is based on head (f6cf2f3) compared to base (7bc1dff). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3213      +/-   ##
==========================================
- Coverage   67.03%   58.30%   -8.74%     
==========================================
  Files         175      209      +34     
  Lines       15948    17667    +1719     
==========================================
- Hits        10691    10301     -390     
- Misses       5257     7366    +2109     
Flag Coverage Δ
integrationtests ?
unittests 58.30% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/data_source.py 81.68% <100.00%> (+23.44%) :arrow_up:
sdk/python/tests/unit/diff/test_registry_diff.py 91.42% <100.00%> (+73.68%) :arrow_up:
...sts/integration/registration/test_universal_cli.py 20.20% <0.00%> (-79.80%) :arrow_down:
...ts/integration/offline_store/test_offline_write.py 26.08% <0.00%> (-73.92%) :arrow_down:
...fline_store/test_universal_historical_retrieval.py 28.75% <0.00%> (-71.25%) :arrow_down:
...ests/integration/e2e/test_python_feature_server.py 29.50% <0.00%> (-70.50%) :arrow_down:
...dk/python/tests/integration/e2e/test_validation.py 27.55% <0.00%> (-69.30%) :arrow_down:
...s/integration/registration/test_universal_types.py 32.25% <0.00%> (-67.75%) :arrow_down:
sdk/python/feast/infra/online_stores/redis.py 28.39% <0.00%> (-66.67%) :arrow_down:
sdk/python/tests/integration/e2e/test_usage_e2e.py 33.87% <0.00%> (-66.13%) :arrow_down:
... and 161 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Sep 14 '22 17:09 codecov-commenter

/lgtm

hemidactylus avatar Sep 22 '22 15:09 hemidactylus

@hemidactylus: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

feast-ci-bot avatar Sep 22 '22 15:09 feast-ci-bot

/lgtm

achals avatar Sep 22 '22 16:09 achals