feast
feast copied to clipboard
feat: Replace zod by protobufjs
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Two issues pending
- Conversion from JSON fails for google.protobuf.Timestamp types (kind of expected, string != {seconds, nanos}) => the UI ends up needing a protobuf binary instead of the JSON string that is exposed today by the backend (unless we find a way to do automatic conversion, which I have not found yet how to do ; we could do regex search/replace but it does not feel like the right way :slightly_smiling_face: )
- I have not found a proto equivalent for featureViewSummaryStatistics and I am still figuring out what to do. Certainly you know better than I do
Except for these two issues, the UI works like a charm with the new protobufjs parsers
Looks like there's still some outstanding issues in showing enum values (e.g. data source enum types)
Codecov Report
Base: 67.71% // Head: 57.93% // Decreases project coverage by -9.77%
:warning:
Coverage data is based on head (
408bd9c
) compared to base (6bc91c2
). Patch coverage: 0.00% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## master #3208 +/- ##
==========================================
- Coverage 67.71% 57.93% -9.78%
==========================================
Files 181 215 +34
Lines 16615 18062 +1447
==========================================
- Hits 11251 10465 -786
- Misses 5364 7597 +2233
Flag | Coverage Δ | |
---|---|---|
integrationtests | ? |
|
unittests | 57.93% <0.00%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
sdk/python/feast/ui_server.py | 23.91% <0.00%> (ø) |
|
...sts/integration/registration/test_universal_cli.py | 20.20% <0.00%> (-79.80%) |
:arrow_down: |
...ts/integration/offline_store/test_offline_write.py | 26.08% <0.00%> (-73.92%) |
:arrow_down: |
...fline_store/test_universal_historical_retrieval.py | 28.75% <0.00%> (-71.25%) |
:arrow_down: |
...dk/python/tests/integration/e2e/test_validation.py | 27.55% <0.00%> (-69.30%) |
:arrow_down: |
...ests/integration/e2e/test_python_feature_server.py | 31.34% <0.00%> (-68.66%) |
:arrow_down: |
...s/integration/registration/test_universal_types.py | 32.25% <0.00%> (-67.75%) |
:arrow_down: |
sdk/python/feast/infra/online_stores/redis.py | 28.39% <0.00%> (-66.67%) |
:arrow_down: |
sdk/python/tests/integration/e2e/test_usage_e2e.py | 33.87% <0.00%> (-66.13%) |
:arrow_down: |
sdk/python/tests/data/data_creator.py | 34.78% <0.00%> (-65.22%) |
:arrow_down: |
... and 168 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: adchia, jerive
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [adchia]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment