feast-dev
Initial implementation of BigTable online store (WIP)
What this PR does / why we need it:
BigTable online-store implementation.
Which issue(s) this PR fixes:
Fixes #
Remaining tasks
- [ ] Write documentation for the BigTable online store
- [ ] Update the implementation to be in line with recommendations from Google (TODO, summarize recommendations here)
- [ ] Clean up the implementation and complete all the TODOs in here
- [ ] Integrate this with the Feast test suite
- [ ] Rebuild all the requirements files
Codecov Report
Base: 67.31% // Head: 57.95% // Decreases project coverage by -9.36% :warning:
Coverage data is based on head (
3c104d8) compared to base (532d8a1). Patch coverage: 36.04% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## master #3140 +/- ##
==========================================
- Coverage 67.31% 57.95% -9.37%
==========================================
Files 179 215 +36
Lines 16324 18062 +1738
==========================================
- Hits 10989 10467 -522
- Misses 5335 7595 +2260
| Flag | Coverage Δ | |
|---|---|---|
| integrationtests | ? |
|
| unittests | 57.95% <36.04%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| sdk/python/feast/repo_config.py | 76.40% <ø> (-5.27%) |
:arrow_down: |
| setup.py | 0.00% <0.00%> (ø) |
|
| sdk/python/feast/infra/online_stores/bigtable.py | 31.46% <31.46%> (ø) |
|
| ...n/feature_repos/universal/online_store/bigtable.py | 58.33% <58.33%> (ø) |
|
| ...ts/integration/feature_repos/repo_configuration.py | 56.59% <100.00%> (-31.12%) |
:arrow_down: |
| ...sts/integration/registration/test_universal_cli.py | 20.20% <0.00%> (-79.80%) |
:arrow_down: |
| ...ts/integration/offline_store/test_offline_write.py | 26.08% <0.00%> (-73.92%) |
:arrow_down: |
| ...fline_store/test_universal_historical_retrieval.py | 28.75% <0.00%> (-71.25%) |
:arrow_down: |
| ...dk/python/tests/integration/e2e/test_validation.py | 27.55% <0.00%> (-69.30%) |
:arrow_down: |
| ...ests/integration/e2e/test_python_feature_server.py | 31.34% <0.00%> (-68.66%) |
:arrow_down: |
| ... and 175 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: adchia, chhabrakadabra
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [adchia,chhabrakadabra]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@adchia I forgot to add the signature in the last commit. I guess I'll have to ask you to lgtm this once more please. 🙏