feast
feast copied to clipboard
ci: Updating GE profiler test case with an actual unrealistic expecation
What this PR does / why we need it:
It looks like the original test case for the profiler did not actually trigger a false expecation. I'm still debugging but this is the first fix. It looks like when an expecation is not met the profiler actually omits the test case, I'll likely fix that in a separate PR but will investigate.
Which issue(s) this PR fixes:
Fixes a bug in the profiler_with_unrealistic_expectations
test.
Fixes #
Codecov Report
Merging #3080 (80001de) into master (66d2c76) will decrease coverage by
9.16%
. The diff coverage is9.09%
.
@@ Coverage Diff @@
## master #3080 +/- ##
==========================================
- Coverage 67.44% 58.28% -9.17%
==========================================
Files 169 207 +38
Lines 14936 17017 +2081
==========================================
- Hits 10074 9918 -156
- Misses 4862 7099 +2237
Flag | Coverage Δ | |
---|---|---|
integrationtests | ? |
|
unittests | 58.28% <9.09%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
...dk/python/tests/integration/e2e/test_validation.py | 27.69% <9.09%> (-69.16%) |
:arrow_down: |
...sts/integration/registration/test_universal_cli.py | 20.20% <0.00%> (-79.80%) |
:arrow_down: |
...ts/integration/offline_store/test_offline_write.py | 26.08% <0.00%> (-73.92%) |
:arrow_down: |
...fline_store/test_universal_historical_retrieval.py | 28.75% <0.00%> (-71.25%) |
:arrow_down: |
...ests/integration/e2e/test_python_feature_server.py | 29.50% <0.00%> (-70.50%) |
:arrow_down: |
...s/integration/registration/test_universal_types.py | 32.25% <0.00%> (-67.75%) |
:arrow_down: |
sdk/python/feast/infra/online_stores/redis.py | 28.39% <0.00%> (-66.67%) |
:arrow_down: |
sdk/python/tests/integration/e2e/test_usage_e2e.py | 33.87% <0.00%> (-66.13%) |
:arrow_down: |
sdk/python/tests/data/data_creator.py | 34.78% <0.00%> (-65.22%) |
:arrow_down: |
...n/tests/integration/registration/test_inference.py | 35.71% <0.00%> (-64.29%) |
:arrow_down: |
... and 166 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: adchia, franciscojavierarceo
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [adchia]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
@franciscojavierarceo looks like there's a test failure!
yeah i'm going to move this back to draft!
New changes are detected. LGTM label has been removed.
@franciscojavierarceo Hey there's a merge conflict!
i fixed this in a separate PR!
Will close it out!