feast icon indicating copy to clipboard operation
feast copied to clipboard

feat: Contrib azure provider with synapse/mssql offline store and Azure registry store

Open kevjumba opened this issue 3 years ago • 2 comments

What this PR does / why we need it: Moving https://github.com/Azure/feast-azure feast_azure_provider package into feast as contrib. Does not move the kubernetes cluster configuration.

Which issue(s) this PR fixes:

Fixes #

kevjumba avatar Aug 11 '22 20:08 kevjumba

Codecov Report

Merging #3072 (516ff76) into master (29f2895) will increase coverage by 8.16%. The diff coverage is 44.50%.

@@            Coverage Diff             @@
##           master    #3072      +/-   ##
==========================================
+ Coverage   67.86%   76.03%   +8.16%     
==========================================
  Files         176      214      +38     
  Lines       15507    17897    +2390     
==========================================
+ Hits        10524    13608    +3084     
+ Misses       4983     4289     -694     
Flag Coverage Δ
integrationtests 66.96% <42.94%> (-0.91%) :arrow_down:
unittests 57.87% <40.31%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/data_source.py 81.68% <ø> (+23.44%) :arrow_up:
sdk/python/feast/feature_store.py 85.60% <ø> (+3.66%) :arrow_up:
sdk/python/feast/infra/provider.py 77.94% <ø> (ø)
sdk/python/feast/infra/registry/registry.py 80.83% <ø> (+5.20%) :arrow_up:
...sts/integration/registration/test_universal_cli.py 100.00% <ø> (ø)
setup.py 0.00% <0.00%> (ø)
sdk/python/feast/type_map.py 57.62% <10.52%> (-2.75%) :arrow_down:
sdk/python/feast/repo_config.py 87.54% <25.00%> (+4.40%) :arrow_up:
sdk/python/feast/inference.py 85.39% <33.33%> (-0.66%) :arrow_down:
...ffline_stores/contrib/mssql_offline_store/mssql.py 38.42% <38.42%> (ø)
... and 119 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Aug 11 '22 20:08 codecov-commenter

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, kevjumba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [adchia,kevjumba]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

feast-ci-bot avatar Aug 19 '22 19:08 feast-ci-bot

/lgtm

adchia avatar Aug 19 '22 20:08 adchia

Hi, I am wondering if it is possible to use this for a self-hosted MSSQL Server database as an Offline Store?

bgalvao avatar Sep 08 '22 13:09 bgalvao