feast-dev
chore: Move registry files to `infra/registry`
What this PR does / why we need it: The sdk/python/feast/ directory is extremely flat, with ~50 Python files. In addition, the registry files are somewhat disorganized right now. This PR (a) moves all the registry files to a new submodule, feast/infra/registry, (b) renames LocalRegistryStore to FileRegistryStore, (c) separates the base registry into its own file, and (d) modifies the RTD docs structure to match these changes.
Which issue(s) this PR fixes:
Fixes #
Codecov Report
Merging #3068 (6e9fe65) into master (081a91a) will increase coverage by
8.81%. The diff coverage is89.96%.
@@ Coverage Diff @@
## master #3068 +/- ##
==========================================
+ Coverage 67.07% 75.88% +8.81%
==========================================
Files 169 207 +38
Lines 15080 17013 +1933
==========================================
+ Hits 10115 12911 +2796
+ Misses 4965 4102 -863
| Flag | Coverage Δ | |
|---|---|---|
| integrationtests | 66.97% <89.80%> (-0.11%) |
:arrow_down: |
| unittests | 58.27% <64.72%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| sdk/python/feast/feature_logging.py | 89.13% <0.00%> (ø) |
|
| sdk/python/feast/infra/gcp.py | 100.00% <ø> (+11.86%) |
:arrow_up: |
| ...ffline_stores/contrib/trino_offline_store/trino.py | 8.72% <0.00%> (ø) |
|
| sdk/python/feast/infra/registry/registry_store.py | 68.42% <ø> (ø) |
|
| sdk/python/tests/integration/e2e/test_usage_e2e.py | 100.00% <ø> (ø) |
|
| sdk/python/feast/infra/registry/registry.py | 80.83% <66.66%> (ø) |
|
| sdk/python/feast/infra/registry/s3.py | 81.66% <81.66%> (ø) |
|
| sdk/python/feast/infra/registry/gcs.py | 87.50% <87.50%> (ø) |
|
| sdk/python/feast/infra/registry/base_registry.py | 93.54% <93.54%> (ø) |
|
| sdk/python/feast/infra/registry/file.py | 94.28% <94.28%> (ø) |
|
| ... and 131 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
At a high level this change seems reasonable to me. I'll wait for tests to be green, and I'm assuming there's no real changes other than refactoring and moving things around.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: achals, felixwang9817
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [achals,felixwang9817]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
