fix: Fix field mapping logic during feature inference
Signed-off-by: Miles Adkins [email protected]
What this PR does / why we need it:
Fixed a bug where field mappings to timestamp and createdstamp were not being skipped over when registering query result as features/entities
Which issue(s) this PR fixes:
Fixes #
Codecov Report
Merging #3067 (8ca47bd) into master (36747aa) will increase coverage by
8.56%. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #3067 +/- ##
==========================================
+ Coverage 67.35% 75.92% +8.56%
==========================================
Files 169 202 +33
Lines 14834 16771 +1937
==========================================
+ Hits 9992 12733 +2741
+ Misses 4842 4038 -804
| Flag | Coverage Δ | |
|---|---|---|
| integrationtests | 67.37% <100.00%> (+0.02%) |
:arrow_up: |
| unittests | 58.05% <25.00%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| sdk/python/feast/inference.py | 87.20% <100.00%> (+3.48%) |
:arrow_up: |
| .../python/feast/infra/feature_servers/base_config.py | 100.00% <0.00%> (ø) |
|
| ...n/feast/infra/feature_servers/aws_lambda/config.py | 100.00% <0.00%> (ø) |
|
| ...ores/contrib/trino_offline_store/trino_type_map.py | 6.66% <0.00%> (ø) |
|
| ...line_stores/contrib/postgres_repo_configuration.py | 100.00% <0.00%> (ø) |
|
| ...ffline_stores/contrib/trino_offline_store/trino.py | 8.72% <0.00%> (ø) |
|
| ...ib/trino_offline_store/test_config/manual_tests.py | 33.33% <0.00%> (ø) |
|
| ...stores/contrib/trino_offline_store/trino_source.py | 5.37% <0.00%> (ø) |
|
| ...ffline_stores/contrib/spark_offline_store/spark.py | 37.41% <0.00%> (ø) |
|
| sdk/python/feast/transformation_server.py | 40.47% <0.00%> (ø) |
|
| ... and 106 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
[APPROVALNOTIFIER] This PR is APPROVED
Approval requirements bypassed by manually added approval.
This pull-request has been approved by: sfc-gh-madkins
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@sfc-gh-madkins do you want to also add the test for _infer_features_and_entities?
@felixwang9817 can we merge to unblock my snowflake materialization PR and i'll add the test on my chore list?
/lgtm