feast icon indicating copy to clipboard operation
feast copied to clipboard

fix: Parse inline data sources

Open felixwang9817 opened this issue 3 years ago • 5 comments

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2991

felixwang9817 avatar Aug 08 '22 21:08 felixwang9817

also note that the test errors here will be fixed once #3037 lands

felixwang9817 avatar Aug 08 '22 23:08 felixwang9817

Codecov Report

Merging #3036 (e733c89) into master (0ed1a63) will increase coverage by 8.53%. The diff coverage is 85.33%.

@@            Coverage Diff             @@
##           master    #3036      +/-   ##
==========================================
+ Coverage   67.44%   75.98%   +8.53%     
==========================================
  Files         169      202      +33     
  Lines       14936    16914    +1978     
==========================================
+ Hits        10074    12852    +2778     
+ Misses       4862     4062     -800     
Flag Coverage Δ
integrationtests 67.05% <26.66%> (-0.40%) :arrow_down:
unittests 58.28% <85.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/cli.py 41.59% <ø> (-0.10%) :arrow_down:
sdk/python/feast/repo_operations.py 49.53% <5.00%> (+24.16%) :arrow_up:
...unit/local_feast_tests/test_local_feature_store.py 97.88% <97.36%> (+66.55%) :arrow_up:
sdk/python/feast/feature_store.py 85.26% <100.00%> (+3.20%) :arrow_up:
sdk/python/tests/utils/cli_repo_creator.py 98.03% <100.00%> (+9.15%) :arrow_up:
...s/contrib/postgres_offline_store/tests/__init__.py 100.00% <0.00%> (ø)
...line_stores/contrib/postgres_repo_configuration.py 100.00% <0.00%> (ø)
sdk/python/feast/loaders/yaml.py 18.18% <0.00%> (ø)
...k/python/feast/infra/materialization/lambda/app.py 26.66% <0.00%> (ø)
..._stores/contrib/postgres_offline_store/postgres.py 35.22% <0.00%> (ø)
... and 102 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Aug 08 '22 23:08 codecov-commenter

nit: have more descriptive PR title since this goes into the changelog

adchia avatar Aug 09 '22 23:08 adchia

@adchia fixed!

felixwang9817 avatar Aug 09 '22 23:08 felixwang9817

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, felixwang9817

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [adchia,felixwang9817]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

feast-ci-bot avatar Aug 15 '22 14:08 feast-ci-bot