feast icon indicating copy to clipboard operation
feast copied to clipboard

feat: Initial Bytewax materialization engine

Open whoahbot opened this issue 3 years ago • 4 comments

What this PR does / why we need it:

This PR adds a Bytewax batch materialization engine.

Which issue(s) this PR fixes:

Fixes #

whoahbot avatar Jul 27 '22 16:07 whoahbot

/ok-to-test

achals avatar Jul 28 '22 18:07 achals

Codecov Report

Merging #2974 (383e3cb) into master (0ed1a63) will increase coverage by 8.50%. The diff coverage is 44.00%.

@@            Coverage Diff             @@
##           master    #2974      +/-   ##
==========================================
+ Coverage   67.44%   75.94%   +8.50%     
==========================================
  Files         169      203      +34     
  Lines       14936    16939    +2003     
==========================================
+ Hits        10074    12865    +2791     
+ Misses       4862     4074     -788     
Flag Coverage Δ
integrationtests 67.01% <44.00%> (-0.44%) :arrow_down:
unittests 58.27% <44.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/repo_config.py 88.80% <ø> (+5.40%) :arrow_up:
setup.py 0.00% <0.00%> (ø)
...on/materialization/contrib/bytewax/test_bytewax.py 45.83% <45.83%> (ø)
sdk/python/feast/cli.py 41.59% <0.00%> (-0.10%) :arrow_down:
...ocal_feast_tests/test_stream_feature_view_apply.py
...ffline_stores/contrib/athena_repo_configuration.py 50.00% <0.00%> (ø)
...offline_stores/contrib/spark_repo_configuration.py 100.00% <0.00%> (ø)
...b/cassandra_online_store/cassandra_online_store.py 2.63% <0.00%> (ø)
...hon/feast/infra/utils/postgres/connection_utils.py 48.00% <0.00%> (ø)
...line_stores/contrib/postgres_repo_configuration.py 100.00% <0.00%> (ø)
... and 102 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Jul 28 '22 18:07 codecov-commenter

@whoahbot looking at this PR now, but do you mind signing your commits? Also you may need a rebase!

achals avatar Aug 11 '22 20:08 achals

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, whoahbot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

feast-ci-bot avatar Aug 15 '22 18:08 feast-ci-bot