feast icon indicating copy to clipboard operation
feast copied to clipboard

chore: Sample grpcurl request along with sample JSON file

Open shim1998 opened this issue 2 years ago • 7 comments

What this PR does / why we need it: This PR helps in giving a sample grpcurl request which can be sent to the grpc server that is created on Feast. More insight on how to send request through JSON is also given as, the format of the JSON file was not specified and was inferred from the sample python file provided in the repository. Which issue(s) this PR fixes:

Fixes # https://github.com/feast-dev/feast/issues/2743

shim1998 avatar May 30 '22 07:05 shim1998

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shim1998 To complete the pull request process, please assign achals after the PR has been reviewed. You can assign the PR to them by writing /assign @achals in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

feast-ci-bot avatar May 30 '22 07:05 feast-ci-bot

/assign @achals

shim1998 avatar May 31 '22 09:05 shim1998

Can you update protos/README.md with some description about these commands?

achals avatar May 31 '22 22:05 achals

/ok-to-test

achals avatar May 31 '22 22:05 achals

Also, @shim1998 you'll have to sign your commits! Details here.

achals avatar May 31 '22 22:05 achals

Hi @shim1998 are you still working on this PR?

achals avatar Jun 21 '22 16:06 achals

@achals i am not able to sign my commits on this, which is why i was blocked on this! I have to end up doing a git pull everytime.

shim1998 avatar Jun 22 '22 10:06 shim1998

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 22 '22 17:10 stale[bot]