feast-spark icon indicating copy to clipboard operation
feast-spark copied to clipboard

Add Synapse Launcher

Open xiaoyongzhu opened this issue 3 years ago • 4 comments

Add Synapse Launcher (with corresponding python dependency and required changes in different files)

What this PR does / why we need it:

To add a launcher support for Synapse

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Yes


Add support for Synapse launcher

xiaoyongzhu avatar Apr 25 '21 09:04 xiaoyongzhu

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xiaoyongzhu To complete the pull request process, please assign woop after the PR has been reviewed. You can assign the PR to them by writing /assign @woop in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

feast-ci-bot avatar Apr 25 '21 09:04 feast-ci-bot

Hi @xiaoyongzhu. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

feast-ci-bot avatar Apr 25 '21 09:04 feast-ci-bot

/ok-to-test

woop avatar Apr 25 '21 15:04 woop

@xiaoyongzhu: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
test-end-to-end-azure-presubmit 8c06c45b3b92367eb4573934903de22fe407382d link /test test-end-to-end-azure-presubmit
test-end-to-end-gcp-presubmit 8c06c45b3b92367eb4573934903de22fe407382d link /test test-end-to-end-gcp-presubmit
test-end-to-end-gcp 6885f31ea55d0b66a9eec66c02d99c3a72103f6f link /test test-end-to-end-gcp
test-end-to-end-aws 6885f31ea55d0b66a9eec66c02d99c3a72103f6f link /test test-end-to-end-aws
test-end-to-end-sparkop 6885f31ea55d0b66a9eec66c02d99c3a72103f6f link /test test-end-to-end-sparkop

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

feast-ci-bot avatar Oct 04 '21 18:10 feast-ci-bot