feast-spark icon indicating copy to clipboard operation
feast-spark copied to clipboard

Update README.md

Open alashti opened this issue 4 years ago • 3 comments

the apply function's arguments were not correctly organized. the feast entity and feature table should be on a list; however, the feature table object will be considered as the project name which should be a string.

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:


alashti avatar Nov 28 '21 12:11 alashti

@alashti: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

feast-ci-bot avatar Nov 28 '21 12:11 feast-ci-bot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alashti To complete the pull request process, please assign pyalex after the PR has been reviewed. You can assign the PR to them by writing /assign @pyalex in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

feast-ci-bot avatar Nov 28 '21 12:11 feast-ci-bot

Hi @alashti. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

feast-ci-bot avatar Nov 28 '21 12:11 feast-ci-bot