rofi-rbw
rofi-rbw copied to clipboard
WIP: Changing help texts
This PR build further upon #48, hence the WIP and I'll fix this once that PR has been accepted or denied.
When calling rbw-rofi
with an --action
argument, the help message and alt-codes in rofi (--mesg
) is unchanged. I think it would be neat to make these adaptive, such that the default action is not an alt-code.
In the case that the help message is not rendered, having it adaptive would be confusing (imo) and thus the list is then a fixed order: both, username, password, menu.
PS: this was my main motivation for PR #48.
When I was writing the description of this PR I realized that not having the default action as an alt-code might be undesired by some users, hence I just added a commit that adds the default action at the end of the action list, but does not render this last action in the help message.
Hi @tosti007, I'd like to prepare a new release. If you think this this PR is still useful, can you either rebase it or drop me a note so that I can have look? Thank you 🙂
Hey @fdw, I think it's best to release it without this PR. I do think it's usefull, but I am not sure if I have time to fix it before the release.
Alright. Feel free to still update when you have time 🙂
Hey @tosti007, how's it looking? 😉
Haha sorry for the large delay, I saw the large update to 1.0.0 and found I didn't have the time at that moment to rebase. I have just fixed it. If you think this shouldn't be added, I'll probably extract some small changes from this PR to a new PR (such as the show_help arg), so don't worry about losing those changes haha.
Because we now support custom keybindings with correct, dynamic help texts, this PR isn't necessary anymore 🙂