telescope-egrepify.nvim icon indicating copy to clipboard operation
telescope-egrepify.nvim copied to clipboard

fix(preview): slightly defer skipping header for correct preview

Open fdschmidt93 opened this issue 1 year ago • 7 comments

Fix #42

@mrbeardad could you please confirm this fixes your issue? :)

fdschmidt93 avatar Jul 10 '24 08:07 fdschmidt93

@fdschmidt93 It is improved, but still exist.

mrbeardad avatar Jul 11 '24 05:07 mrbeardad

Initial usage of this branch looks to fix it for me (again, initial usage, will continue with this branch through out the day and report back). thanks for filing this @mrbeardad and thanks for the plugin and fixes, @fdschmidt93!

megalithic avatar Jul 11 '24 16:07 megalithic

It works good in mini init.lua, but not after install lots of plugins that make my nvim slow.

mrbeardad avatar Jul 13 '24 03:07 mrbeardad

I'm afraid this is a mega stupid bug. The solution now is also quite hacky, but anything else didn't seem to always work or would be significantly more complicated.

Please confirm this resolves this issue fully on your end :)

fdschmidt93 avatar Jul 13 '24 12:07 fdschmidt93

@fdschmidt93 I'm sorry for the late reply. The issue about the wrong preview position is gone, but there is another bug that does not appear in master, to reproduce it:

  1. type <space>/ to open egrepify
  2. type a to search something
  3. type <c-p> to select previous item
  4. ui freezed until type <c-c> to interrupt (expect to select the last item)

mrbeardad avatar Jul 18 '24 13:07 mrbeardad

Thanks for reporting! Haven't tried reproducing but can very well imagine that this happens.

I'm afraid I most likely will only be able to be getting back to this some time in August. My apologies.

fdschmidt93 avatar Jul 18 '24 13:07 fdschmidt93

Thanks for your working on this :)

mrbeardad avatar Jul 18 '24 13:07 mrbeardad

@fdschmidt93 @mrbeardad I fixed this problem in a slightly different way for myself could you take a look, does it make sense.. https://github.com/fdschmidt93/telescope-egrepify.nvim/pull/48

ykaratkou avatar Oct 03 '24 09:10 ykaratkou

Closing this as superseded by #48

Thank you @evkorotkov!

fdschmidt93 avatar Oct 03 '24 13:10 fdschmidt93