Faisal
Faisal
Hey @mparaz if you have a solution for snowflake we can take a look at the proposal and see how we could implement it for pandas and the other types....
@mparaz Just confirming is this ready for review? might need some linting so the CICD can pass.
@rhaffar if you have some time on friday maybe to just test everything out offline and run it against a live cluster?
Just waiting on #424 to get merged in and then will rebase this PR for final review. etc. If it is OK I might push some changes to your branch...
@goodwanghan @kvnkho FYI, no pressure to contribute, but something in our backlog I'm thinking to ensure full parity in terms of function etc.
I'm good with the programatic execution here. It makes sense to me people would want to automate as much as possible within some thresholds etc. We should refine the intent...
Sure, this one might be meaty. I think I have some work done in #195 which has just been sitting, but I'm not sure if the Pandas Spark API is...
> I think this is a really cool idea - and for the benefits it provides I think it's actually a pretty low-effort change. Couple questions: > > * I'm...
> I like the idea of modularity as well as dispatching as well. Maybe we could have a ABC class with a general `compare` method that does the actual comparison,...
@rhaffar @ak-gupta @gladysteh99 I have 2 implementations here we can discuss: https://github.com/capitalone/datacompy/compare/v1-refactor Single dispatch verison: https://github.com/capitalone/datacompy/blob/v1-refactor/datacompy/comparator/string.py Individual class based: https://github.com/capitalone/datacompy/blob/v1-refactor/datacompy/comparator/numeric.py