opam-repository-mingw icon indicating copy to clipboard operation
opam-repository-mingw copied to clipboard

Published 20 hours ago • verified publisher icon fdopen

Stop Patching in Broken Image-Base Behavior in Flexdll

Open EmmaJaneBonestell opened this issue 3 years ago • 1 comments

Since September of 2020, flexdll no longer passes image-base because it will create DLLs/plugins with relocations too far to be loaded.

https://github.com/alainfrisch/flexdll/issues/50 https://github.com/alainfrisch/flexdll/pull/89 https://github.com/ocaml/ocaml/pull/10351

OCaml versions 4.12.1 and newer need to stop passing this flag, but the inline-flexdll.patch is outdated and still implements this behavior on new versions of OCaml.

EmmaJaneBonestell avatar Feb 19 '22 21:02 EmmaJaneBonestell

The problem with the new solution is that it requires changes to external stub code. When the new OCaml version appeared, of course, no one had adapted the source code yet. I left the hack so that everything wouldn't stop working all at once. But you are right. Meanwhile some time has passed, I will release OCaml 4.14/flexlink 0.40 without it.

fdopen avatar Mar 13 '22 13:03 fdopen