Darren Schroeder comments

Results 2077 comments of


                                            Darren Schroeder

completion_menu crashes if `only_buffer_difference` is `true`

confirmed in 0.85.1 it still crashes ``` 📎 cd thread 'main' panicked at 'assertion failed: self.is_char_boundary(idx)', /rustc/90c541806f23a127002de5b4038be731ba1458ca\library\alloc\src\string.rs:1532:9 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ```

completion_menu crashes if `only_buffer_difference` is `true`

yup, i just tested and it doesn't crash. another issue though is `cd ` should bring up folders and not everything plus it doesn't `# Search is done on the...

Highlight valid paths

This is theoretically possible but we would need it behind the `use_ansi_coloring` config flag if implemented since this uses ansi escapes to draw the underline.

the shortcut to scroll through previous commands in the current session

nice! This works well. It would be good to find a place for things like this in our nu_scripts repo.

the shortcut to scroll through previous commands in the current session

We're up for someone working on that functionality in reedline and then brining it over to nushell.

the shortcut to scroll through previous commands in the current session

I was looking today in the code and saw that we can have `modifier: alt` and `keycode: up` and call some code in a keybinding. We know we can clearly...

Argument type checking on def

Making this a draft. Not sure if progress needs to continue on this or not.

Argument type checking on def

@jntrnr can you check to make sure your points have been addressed?

Argument type checking on def

What's the status on this PR?

`str replace` should use plain string by default

I wonder if this is related to @bobhy's recent PR https://github.com/nushell/nushell/pull/7883 ?