Darren Schroeder
Darren Schroeder
> P.S. I recommend resetting back to 62272975f at the latest to test this change. From 1867bb1a8 onwards there's a bug with flag arguments trying to convert strings to booleans...
There are some use cases for `--flag=true` but most of what I've seen are for forwarding flags to other programs and doing flag parsing inside of a custom command.
Weird indeed. ``` thread 'commands::touch::change_dir_times_to_reference_dir' panicked at crates\nu-command\tests\commands\touch.rs:322:9: assertion `left != right` failed left: SystemTime { intervals: 133519057186339154 } right: SystemTime { intervals: 133519057186339154 } ```
I thought this would be a quick and easy change, but unfortunately it looks like we're having lots of issues. With that in mind, we've planned on moving to uutils/coreutils...
I'm running the tests in Windows now just to see if I get the same error
I just changed the test to this and the first part passes. ```rust // Change the times for reference filetime::set_file_times( &reference, filetime::FileTime::from_unix_time(1337, 1337), filetime::FileTime::now(), ) .unwrap(); ``` I decided to...
I'm fine with having tests that only run on windows and others that run on unix. > That can't be right. I could be doing something wrong but I have...
@kik4444 can you fix the conflicts? I'm thinking we can probably land this if we can get the ci green.
Does this one need to be closed?
consistency is a plus for sure.