Darren Schroeder comments

Results 2076 comments of


                                            Darren Schroeder

nu-table: Improve `table -a`

@zhiburt one more question. i just want to make sure this stream collect is only being called with -a, we don't want to be collecting on other table modes. can...

`move`-Command Tests, Refactor, Fix

Other than my comment above I think this looks good. Thanks!

`move`-Command Tests, Refactor, Fix

Thanks for helping make nushell better!

Remove unused `Index(Mut)` impls on AST types

I wonder if these were added by consumers of nushell crates like couchbase-shell? 🤔 Nope - doesn't look like it https://github.com/nushell/nushell/pull/4482

Command `debug info` reports incorrect mem usage

Hmmm, I'm pretty sure this all used to work. I wonder if something broke it recently (like sysinfo). It looks funky in Windows too ![image](https://github.com/nushell/nushell/assets/343840/66b6e937-66c3-446d-877c-9256028052a6)

Command `debug info` reports incorrect mem usage

Definitely something changed here. The Process struct isn't being populated like it once was. ``` ❯ debug info | table -e Some( Process { pid: Pid( 5776, ), parent: Some(...

Command `debug info` reports incorrect mem usage

I think I've got it fixed. If you have time @dmatos2012 it would be good if you could check #11909 to see if it fixes it for you.

`open`, `rm`, `umv`, `cp`, `rm` and `du`: Don't globs if inputs are variables or string interpolation

A much more radical approach to number 2 of @kubouch's comments above is to remove globbing from every command and only allow globs via the glob command and the used...

`open`, `rm`, `umv`, `cp`, `rm` and `du`: Don't globs if inputs are variables or string interpolation

How does this perform with Kubouch's glob torture tests? BTW, I put it here so we can make changes to it easily https://hackmd.io/y5yMvEnrR7WTLH3vVBQlFg?edit