Frankie Dintino

Results 135 comments of Frankie Dintino

I do experience lag and performance issues, and with hundreds of nodes it becomes unusable. But those performance issues are fixed (for me) with the overridden definition of `PureEditorContent.prototype.maybeFlushSync` I...

@AdventureBeard are you seeing the cursor behavior changes with the first or second patch that I posted?

I wonder if there are other places where state dependencies aren't fully accounted for, but they hadn't caused issues before because this bug was rerendering all components on every keystroke.

I am assuming you're both referring to my patch and not @Zloka's, but it's probably worth clarifying that.

I'm not seeing that behavior. I was thinking of putting together a PR with this change, so if you could provide a minimal test case I would appreciate it. I...

Sure. [Here's a codesandbox](https://g6r9lh.csb.app/) demonstrating the problem, with a toggle between tiptap-react, a vanilla js nodeview, and a version with my patch and @Zloka's above. The number in the left...

That can be achieved by wrapping the component in `React.memo`, since for this particular component it's not using any of the props. For me, this gives comparable performance: ```tsx const...

I've found that `setLink` _is_ sufficient for adding the mark (at least in the latest version of tiptap), so long as you set the selection after inserting the text: ```tsx...

I seem to have had the bad luck of having had this issue assigned to someone who has never commented on or updated an issue on this repo. Tagging @rchiodo...

Would there ever be a future where we might account for chroma subsampling in `ImagingMemoryInstance`? If so, I imagine we might also use a null `arrow_band_format` for that?