François Degros

Results 51 comments of François Degros

> Please what is the purpose of this pull request? The purpose of this pull request is to provide an easy and simple reproduction of bug #2513 to `libarchive`'s maintainers....

> I've included your test case in #2706, which I believe fully fixes this bug (and a similar bug in grzip support). Good catch, `grzip` also had the same issue....

> Seems like mount-zip-1.0.12 is a good candidate for stabilization, so why not stabilize it instead of removing it? This change just upgrades `mount-zip` to the latest released version, which...

> Conveniently, it looks like `archive_read_data_block()` stores the original file size in the `*offset` parameter when returning `ARCHIVE_EOF` after the last block. Further testing with `libarchive` 3.7.4 indicates that this...

Another source of confusion is that, sometimes, `archive_read_data_block()` reports an empty data block by returning `ARCHIVE_OK` and setting its `*len` parameter to zero. Testing with `libarchive` 3.7.4 seems to indicate...

The test archive `Many.zip` contains 100 top folders that contain 1000 files each. That's a total of 100,000 files of 15 bytes each, which are stored without any compression. See...

I also noticed that the "system" time was doubled by commit 7a53a1acf29221b1e65b2a34e1a295621e769592. So I traced the system calls using the following command before and after commit 7a53a1acf29221b1e65b2a34e1a295621e769592. ``` # At...

> We've moved the call to `localtime()` from `zip_open()` to `zip_stat()`. This change makes each call to `zip_stat()` significantly more "expensive" (i.e. slower). This has surprising performance implications. I checked...

Oh great. Thanks. I confirm that commit c2854bea92f8d63aa1881e53c657e07fdc09e6fb fixes the performance regression. At commit 46e309f3bcab21d4edec19a603c63e6a078632d6 (which is just before the commit that fixes the performance regression): ``` $ time mount-zip...

Would you now consider releasing an official version containing this fix? That would allow me to simply upgrade the version of `libzip` we are using instead of extracting, preparing and...