Frank DeFalco

Results 23 comments of Frank DeFalco

I think Patrick echoed my concern on transparency here: https://forums.ohdsi.org/t/osm-vocabulary/16303/11

We are discussing the changes to be made as part of this issue here, informed by the conversation there. I don't think there is any debate regarding the need for...

need to add distribution values from achilles_results_dist to visit_occurrence, visit_detail, drug_era, and condition_era exports in AOExport function.

This looks like a typo. As to why there is a subject_id column in the cohort table, that is based on a very old decision that the cohort table could...

It is indeed very polite, but only if you are using Redshift? Everyone else gets rude behavior? 😄 I was thinking perhaps an overwrite parameter for the function that can...

There are a few issues that occur with the log file. If the string search fails we can see errors or in the case like this with an existing log....

@TomWhite-MedStar Thanks for your PR. @chrisknoll is correct with his recommendations regarding our limiting use of CTE. Could you provide hardware specifications of your Spark environment? Do you have any...

Ok thanks. The Achilles 1.7.1 release is currently pending CRAN approval. Achilles is also being added to HADES as it has not achieved compliance with HADES standards. This might delay...

> Hi @fdefalco, Is there any timeline for when the PR will be reviewed? I can review and merge if you'd like. Current priority is having the CommonDataModel package added...

I believe these have been addressed by PR #761 and #756