brackets-typescript icon indicating copy to clipboard operation
brackets-typescript copied to clipboard

Updated Language Service API.

Open RReverser opened this issue 11 years ago • 7 comments
trafficstars

  • Updated Language Service to Microsoft/TypeScript@6287efc24de2113c0e6e9b8caea7f179c0e11af2 with corresponding API changes.
  • Removed typescriptServices.js from bin/main.js and bin/worker.js bundles, loading dynamically instead.

New API is unstable as it's part of new compiler rewrite, but might be useful to start migrating to it as earlier as possible since it breaks compatibility for older code.

RReverser avatar Aug 16 '14 16:08 RReverser

Anyway I would prefer to work on a special branch, since master should always be installable with install from url feature of brackets

fdecampredon avatar Aug 18 '14 09:08 fdecampredon

Np, I thought about that after sending PR. Unfortunately, it's not possible to select another branch after sending it, so there are still options of closing+reopening as another one on my side, or, merging manually to develop branch locally on your side.

RReverser avatar Aug 18 '14 09:08 RReverser

For the moment since you still want to commit something just work on this PR, I'll review it after your commit then merge on another branch manually.

2014-08-18 11:23 GMT+02:00 Ingvar Stepanyan [email protected]:

Np, I thought about that after sending PR. Unfortunately, it's not possible to select another branch after sending it, so there are still options of closing+reopening as another one on my side, or, merging manually to develop branch locally on your side.

— Reply to this email directly or view it on GitHub https://github.com/fdecampredon/brackets-typescript/pull/31#issuecomment-52469501 .

fdecampredon avatar Aug 18 '14 09:08 fdecampredon

Fixed loading, but there is still some weird bug with autocomplete. Spent few hours looking for reason, but no luck as for now.

RReverser avatar Aug 18 '14 15:08 RReverser

@fdecampredon Ah, looks like it's problem in new TypeScript Language Service that doesn't normally handle built-in references i.e. to modules declared with declare module ... and so fails in assertion createCompilerHost().getSourceFile(filename) since reference is actually not a filename.

Autocompletion works fine on small test projects with few files that depend on each other, so it's generally possible to start experimenting while waiting for stabilization of new API.

RReverser avatar Aug 18 '14 23:08 RReverser

Submitted this issue as Microsoft/TypeScript#492.

RReverser avatar Aug 20 '14 20:08 RReverser

@fdecampredon Submitted fix for that issue & merged it here.

RReverser avatar Aug 20 '14 21:08 RReverser