fdeantoni

Results 29 comments of fdeantoni

Proto spec is to serialize int64 to String

Interesting! Do you have a sample proto message with a code snippet that recreates this behaviour? Better yet if it could be a test case we can add to the...

Any Message::parse_from_bytes

The message handling functions are all from tokio-rs/prost. This library just provides the serde parts for the protobuf WellKnownTypes. Better to raise this one with tokio-rs/prost.

Missing fields are not handled correctly.

To be honest I have not had to deal with proto2 that much so did not really consider these scenarios. I suspect the marking of whether a field was set...

Suggestions for oneof handling

This is an interesting solution as well. I will add it to the README as an alternative.

Should be message oriented

Thanks for this issue @frehberg! Its a problem that has vexed me for some time. I was thinking perhaps this could be solved though enums generated by a macro, similar...

Actor capable of handling multiple messages concurrently

Thanks for this issue @NotAPenguin0! It's indeed a problem that an actor can block and then stop processing messages. My initial hunch would be to implement something akin to Akka's...

Change parameter type of Any::try_pack.

Many thanks for putting together this PR! I will review and see what the best way forward is. I agree it might be best to avoid a breaking change and...

Convert between prost_wkt_types::Value and serde_json::Value?

For my use case there was no reason yet to implement this but I suppose it can be added. I'm not sure yet if this should be a From or...

Help on compilation error

I will need to investigate this a little further. What version of rust were you using?

`google.protobuf.rs` becomes bigger after each build

Thanks for raising this! Indeed not good if the file keeps growing. I will dig a little deeper to see what the best solution is.