Fahim Dalvi

Results 23 comments of Fahim Dalvi

Hi @rasbt, Thanks for the quick reply, that makes a lot of sense! Given that the primary difference is the data, would it be better then to have a shared...

I appreciate your perspective. If its okay, I'll open a PR sometime soon that brings the two codebases closer together where applicable (FSDP settings, model loading, perhaps a few more...

FWIW, some data readers such as `TextFiles` ignore the data.num_workers argument (no reference to `self.num_workers` set in the constructor: https://github.com/Lightning-AI/litgpt/blob/2f2ea8ca44d1fe41bdeb3a06f49da06930272984/litgpt/data/text_files.py#L69), so this might also be a source of confusion. I...