boilerplate-vite-react icon indicating copy to clipboard operation
boilerplate-vite-react copied to clipboard

✨ feat(commitlint): add commitlint and husky hook

Open hedenica opened this issue 4 years ago • 5 comments

hedenica avatar Feb 23 '22 16:02 hedenica

@fdaciuk 👀

hedenica avatar Mar 02 '22 17:03 hedenica

Hey @hedenica! Sorry, I'll check that out soon :D

fdaciuk avatar Mar 02 '22 19:03 fdaciuk

Hey @hedenica! It works like a charm on Linux, but Windows cried a bit xD When you try to use this on Windows (Powershell terminal), every pressed key will print all the content again:

That shit happens with every option on the cz CLI:

Do you want to try find something about this issue? Because if this is a no solutionable problem, I think we can change the approach: instead of using cz directly with Husky, we can use this command as an NPM Script (yarn commit or something).

What do you think?

fdaciuk avatar Mar 07 '22 09:03 fdaciuk

Heey! Sorry for the delay 😄
I'll take a look at this as soon as I can, but I do think that we're gonna have to change the command.

hedenica avatar Mar 11 '22 16:03 hedenica

No problem! :D It's ok for me to create a new command :)

fdaciuk avatar Mar 13 '22 15:03 fdaciuk