Flavio Curella

Results 121 comments of Flavio Curella

I dont see any issues with falling back to `typing_extension` on

Can't this be fixed by using some kind of `TypeVar` in the type hint of `uuid4`?

@parsariyahi using `numbers.Number` seems like the right solution here. Do y ou have time to prepare a Pull Request?

turns out, [`Decimal` is not part of `numbers.Number`](https://peps.python.org/pep-3141/#the-decimal-type). I've tried using `Union[Decimal, int, float]`, but looks like `abs()` doesn't accept `Decimal`, so the best I can do is to define...

The [PEP for Decimal](https://peps.python.org/pep-3141/#the-decimal-type) states: > After consultation with its authors it has been decided that the Decimal type should not at this time be made part of the numeric...

Hi! Could you push something to your branch, so that workflow can run again?

the stub file (`faker/proxy.pyi`) is meant to be autogenerated by [`generate_stubs.py`](https://github.com/joke2k/faker/blob/master/generate_stubs.py), which currently does not recognize `@overload`ed signatures. Could you look into adding support for `@overload` to `generate_stubs.py`?

I'm confused, `phone_number` does support different formats. See the [`en_US` localization](https://github.com/joke2k/faker/blob/master/faker/providers/phone_number/en_US/__init__.py) for example. Are you setting the locale when you instantiate `Faker`?

After reading your comment on https://github.com/joke2k/faker/issues/1588#issuecomment-2137234566, I think I see what you're saying. I'm ok with adding the parameter. Feel free to submit a Pull Request and I'll be happy...

@Abdujabbar I think your should is the best option. If any of you want to submit a Pull Request, I can re-open this ticket :)