tmux-thumbs icon indicating copy to clipboard operation
tmux-thumbs copied to clipboard

Published 20 hours ago • verified publisher icon fcsonline

Let's nix

Open ghostbuster91 opened this issue 2 years ago • 6 comments

Hi,

I've just found your plugin and it is awesome :) I recently started configuring my tmux as finally I have option to build my environment in a reproducible way and experiment safely thanks to lord and savior nix.

This plugin is not available (yet) in the official nix package repository (I might add it there as soon as I figure how :D ) but that is not a problem, rather a small inconvenience as it can be build from sources.

I tried doing it on my own, but after couple failed attempts I decided to look for the help on the internet. I found that someone already did that: https://git.alarsyo.net/alarsyo/nixos-config/src/branch/tmux-thumbs/packages/tmux-thumbs.nix

Unfortunately, that doesn't work for me for some reason. I examined his patch and it looks fine to me. Maybe that's because I am using the latest version of tmux - 3.2a? :thinking:

Anyway, as you can see in the linked repository, the author needed to apply some patch to both rust and sh files. It would be the best to avoid such hacks if possible.

To the point - do you think that it would be possible to make such changes so the nix-patch wouldn't be needed?

ghostbuster91 avatar Jan 08 '22 12:01 ghostbuster91

Recording of my screen with blinking thumbs pane in the status bar: Peek 2022-01-08 13-03

ghostbuster91 avatar Jan 08 '22 12:01 ghostbuster91

The installation process has changed in the last days. Can you check again?

fcsonline avatar Feb 05 '22 15:02 fcsonline

Hi,

It turned out that the problem was in the linked patch. I managed to fix it and make it running for the latest version - 0.7.1 :)

Here is how I did it: https://github.com/ghostbuster91/dot-files/commit/d263bf7e9e5084e54bfb2aaf877214e45a595f66

ghostbuster91 avatar Feb 24 '22 22:02 ghostbuster91

Awesome!! Should we close the issue?

fcsonline avatar Feb 26 '22 14:02 fcsonline

Let's do that :)

ghostbuster91 avatar Feb 26 '22 15:02 ghostbuster91

fyi I submitted PR to nixpkgs repository to add thumbs and tmux-thumbs: https://github.com/NixOS/nixpkgs/pull/162121/

I submitted myself as a maintainter of that nixpkg if you don't mind.

Please let me know if you want to make any changes or have anything against it.

=============================

Also sorry for my indecision, but I think that it would be great if we could get rid of those hacky patches. I would like to keep this issue open to discuss possible ways of making them redundant.

Let me know if you are open to fix that at all, otherwise feel free to close that issue.

ghostbuster91 avatar Feb 27 '22 23:02 ghostbuster91