react-transmission icon indicating copy to clipboard operation
react-transmission copied to clipboard

Published 20 hours ago • verified publisher icon fcsonline

Add themr to allow themes

Open pierrickrouxel opened this issue 7 years ago • 4 comments

All components use react-css-themr.

It's now possible to build themes for react-transmission. This allows to develop a new UI without lost the goal of keep the same UI of actual transmission web client.

pierrickrouxel avatar Sep 10 '17 19:09 pierrickrouxel

Thanks for your contribution but it goes against one of our main project rule.

This rule says that we need to keep the same UI like the old interface before being accepted by the main Transmission project. After being accepted we can talk about changing themes and UI refactors.

fcsonline avatar Sep 30 '17 12:09 fcsonline

I didn’t change theme. All CSS stay as this. I just prepare the future. I think you shouldn’t reject this PR. I spent lot of time to integrate themr. I will not redo this work on the futur version.

pierrickrouxel avatar Sep 30 '17 14:09 pierrickrouxel

Sorry if my answer was a bit rude. Hard days in my city, Barcelona. 😢

fcsonline avatar Oct 02 '17 08:10 fcsonline

👍 for merging too, this wouldn't compromise UI goals and would allow users to customize look and feel to their liking.

jasonm23 avatar Aug 20 '18 08:08 jasonm23