drill #59 get no_proxy in from reqwest

#59 get no_proxy in from reqwest

Open zoosky opened this issue 2 years ago • 5 comments

Reqwest 0.10.10 has system proxy / no_proxy support included.

Nov 26 '21 10:11 zoosky

no_proxy support is often a requirement in corporate use cases.

Nov 29 '21 12:11 zoosky

It is good to have dependencies up to date but I don't understand this change. no_proxy is supported in the current version.

https://docs.rs/reqwest/0.10.4/reqwest/struct.ClientBuilder.html#method.no_proxy

Why this change?

Dec 02 '21 19:12 fcsonline

I tested it with Reqwest 0.10.4 with no success. Then I patched drill to use Reqwest 0.10.10, and it worked as expected. See also

## v0.10.7

- Add `NO_PROXY` environment variable support.

https://github.com/seanmonstar/reqwest/compare/v0.10.4...0.10.x

Dec 02 '21 20:12 zoosky

If you opt in for upgrading reqwest 0.10.10, the NO_PROXY issue is solved and a NO_PROXY setting in the env is supported.

Jul 01 '22 05:07 zoosky

Why this change? no_proxy setting only worked with this change according to my tests behind corp proxy.

Nov 18 '22 19:11 zoosky