François Chollet
François Chollet
Sure -- there's no rush! Thanks for working on this!
Thanks for the update -- the functionality looks great! I think the interface could look more professional though. Maybe we can first focus on the HTML version of the interface...
> I didn't understand what you meant by referring that the interface could look more professional, could you clarify a bit for us to know what we should change? Sure....
> Just to clarify, you would like us to make the compare_models interface look more professional, like the inspect_file interface? Yes, exactly -- preferably something with interactive HTML. It could...
Thank you for the contributions here so far -- we merged a subset of this feature in `keras/src/saving/file_editor.py`. Currently it only really works with the CLI and not HTML/js, but...
> if https://github.com/keras-team/keras/blob/master/keras/src/random/seed_generator.py#L80 can be changed to something like f"{self.name}_generator_state" it will work with ParameterDict approach. The uniqueness of the variable path should come from the parent object name, not...
> the spirit of this change is to let torch module to handle the recursive collection so i was planning to use variable name but find out that there are...
> the failing pytorch test is actually passing on my env: Works for me locally as well. Might be a fluke.
There are actually various tests that reliably fail here: https://btx.cloud.google.com/invocations/c55a2ca4-5df3-411b-bd52-7c9873e839ce/targets/keras%2Fgithub%2Fubuntu%2Fgpu%2Ftorch%2Fpresubmit/log (not the numerical integration test)
> is it possible to configure ci to run pytest regardless whether integration test passes or not? We'd have to move the integration testing to go after the general pytest...