Formulary icon indicating copy to clipboard operation
Formulary copied to clipboard

Add ability to disable rows

Open tp opened this issue 10 years ago • 3 comments

I think hiding rows that can not (yet) receive input makes for a noisy UI, so I think rows should be allowed to be enabled / disabled

tp avatar Aug 08 '15 17:08 tp

Seems useful. I'd love to see a proposal for what the api for something like this would look like.

:penguin: :thought_balloon:

fcanas avatar Aug 09 '15 01:08 fcanas

Great. At the moment the relationship between the FormRow and the actual UITableViewCell holding the data seems a bit weak, with the Cell having to set the value on the row and calling action.

And I see no easy way to update the Cell when the FormRow changes.

tp avatar Aug 09 '15 06:08 tp

It could be nice to have full bidirectional binding between rows and cells. :repeat: but I think the current solution is serviceable. I'll leave this issue open for a while to discuss the bidirectional binding before I dive into implementing it.

Current status:

If you change the edit-ability of a Form or FormSection, or change enabled on a FormRow, you're changing a model layer which will not have immediate effects on its corresponding view (the cell) :dancer: . If, however, you change the edit-ability of the FormViewController, it will set the same on the model, and effect the change in the view layer as well. :dancers:

It may not be in its final form, but it's inching along :bug: and at least a little more useful :confetti_ball:

fcanas avatar Aug 10 '15 14:08 fcanas