bas smit
bas smit
> I'm not sure how hard to implement it, but it seems really useful. Some (minor) comments: > Which version do you prefer? Probe like or struct like? > *...
> ### probe syntax > > The disadvantage in my opinion is the syntax doesn't really fit super well. If you squint at the code it makes sense but if...
Core of the problem is ``` char* demangled_name = cxxdemangle(fun_line.c_str()); if (demangled_name) { if (!wildcard_match(prefix + demangled_name , tokens, true, true)) { free(demangled_name); } else { free(demangled_name); goto out; }...
> I would be a bit wary of trying to be too smart, I think it's possible for the same binary to have `myfunc` as a C symbol as well...
> > I don't think its that smart. Instead of having myfun match _myfun_ we'd have myfun just match myfun but that does require us to be able to extract...
> I'm fine with allowing the `:c++` prefix, but I wouldn't force users to do so in this case, as name mangling is not a C++ specific feature. For the...
@lathiat poke
Overlaps with #1006 I think. Useful but I think it needs kernel support.
Noticed my comment from the last version got lost: > Being able to read in loooooooong strings would be great but I don't think we should change the current behaviour...
> Do you have a program handy that uses a syntax like `@[str(arg0)]=arg1`? I'd like to try it out and see if the new str() is still compatible. I may...