Frank Brütting

Results 76 comments of Frank Brütting

> In summary: we are OK to change this given we know what color to pick. The restriction is that: > > 1. It has to be one color (as...

In the shell it sure is, I just don’t know how Julia interfaces with that. Shells use strange color codes like `\033[31m`, as you can see in my link above.

You can also substitute `:dark_gray` by `(127,127,127)` in your referenced code. I just tested this.

While we’re at this: Is it possible to specify this color as an environment variable or by a function call? I guess that would be nice for circumventing corner cases...

> Isn't this the same problem as [JuliaLang/julia#38730](https://github.com/JuliaLang/julia/issues/38730) caused by the fact the solarized theme uses same colours for background and foreground? Yup, seems so. Thanks for the tip, now...

> > In the past we have had a policy not to introduce behavior depending on global state. > > @nalimilan - in this case do you think it would...

Of course, here it is for Solarized Dark and Light: (btw: `echo -e` was necessary) I think 243 provides the best readability for both variants. ![Bildschirmfoto vom 2023-11-13 13-47-47](https://github.com/JuliaData/DataFrames.jl/assets/10520767/e4383779-86c4-45d2-9028-6be98c5b6bf6)![Bildschirmfoto vom...

Not having a good contrast is much less of a problem than not seeing those values at all, so I’d still prefer hardcoding medium gray. Here’s a comparison of common...

That would lead to invisible text in Solarized Dark, like in the Julia-issue referenced above. Same order as above: ![Bildschirmfoto vom 2023-11-13 16-49-02](https://github.com/JuliaData/DataFrames.jl/assets/10520767/29344562-015c-41ef-be09-2bf5b9a74600) ![Bildschirmfoto vom 2023-11-13 16-49-09](https://github.com/JuliaData/DataFrames.jl/assets/10520767/52188fcd-1819-4a56-bdcc-19f575695d67) ![Bildschirmfoto vom 2023-11-13...

For avoiding negative external impact (other package managers might also run into that, I guess) – would it make sense to internally block reinitiation of that action for some deadtime...