symbol-bootstrap icon indicating copy to clipboard operation
symbol-bootstrap copied to clipboard

Published 20 hours ago • verified publisher icon fboucquez

Bootstrap network improvements

Open fboucquez opened this issue 3 years ago • 6 comments

This PR is the bootstrap changes required before the lerna split and symbol-network app.

There are several improvements.

  • custom preset cached on target
  • Renamed bootstrap preset for dualCurrency. Added singleCurrency preset.
  • Removed unused genesis state files after generating
  • Nemesis seed is shared across the different nodes avoiding duplicated files.
  • Improved unit testing. Heavily tested using expected target zip with lots of network/assembly/customPreset combinations.

Fixes https://github.com/nemtech/symbol-bootstrap/issues/60 Fixes https://github.com/nemtech/symbol-bootstrap/issues/245 Fixes https://github.com/nemtech/symbol-bootstrap/issues/80

fboucquez avatar Jul 06 '21 13:07 fboucquez

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
1.1% 1.1% Duplication

sonarqubecloud[bot] avatar Jul 24 '21 11:07 sonarqubecloud[bot]

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 11 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Nov 26 '21 13:11 sonarqubecloud[bot]

Why there are so many changes packed in a single review?

gimre-xymcity avatar Nov 30 '21 08:11 gimre-xymcity

what is the status of this?

gimre-xymcity avatar Dec 09 '21 15:12 gimre-xymcity

what is the status of this?

I'm a 2-3 of PRs away before dropping this branch. Once we have the other PRs merged, the first version of symbol-network would be able to use the official symbol-bootstrap lib.

https://github.com/fboucquez/symbol-network https://hackmd.io/Ak7Sl1A6SkKV7ga0QW00LA

Eventually, if you are keen, symbol-network could be a submodule of symbol-bootstrap, similar to how this branch looks https://github.com/symbol/symbol-bootstrap/tree/multimodule (lerna multimodule monorepo)

fboucquez avatar Dec 09 '21 16:12 fboucquez

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jan 14 '22 20:01 sonarqubecloud[bot]