Francis Bogsanyi
Francis Bogsanyi
@dylanahsmith : "I think the only thing that prevented us from storing `nil` was that `cache.read` would return `nil` for a cache miss as well as if the value cached...
https://github.com/open-telemetry/opentelemetry-ruby/pull/631 https://github.com/googleapis/google-api-ruby-client/pull/3185
Our Rack instrumentation allows configuration of a URL quantization function https://github.com/open-telemetry/opentelemetry-ruby/blob/1c37b00dc82d490dace1f92739977aa4674d7039/instrumentation/rack/lib/opentelemetry/instrumentation/rack/middlewares/tracer_middleware.rb#L122-L137 We should add the same functionality to the Sinatra instrumentation. @genebean reported this requirement in Gitter: > I am...
Follow on from open-telemetry/opentelemetry-ruby#230 and open-telemetry/opentelemetry-ruby#263.
Example: ```ruby _( easy.instance_eval { @otel_original_headers['traceparent'] } ).must_equal "00-#{span.trace_id.unpack1('H*')}-#{span.span_id.unpack1('H*')}-01" ``` This is a very common pattern in the adapter tests. It’s worth thinking about extracting this to a helper in...