Francis Bogsanyi
Francis Bogsanyi
All the gems that access `instrumentation_scope` from the span data object will need to update their SDK dependency to a minimum of the SDK version that releases this change. We...
We should add a deprecation notice to the `InstrumentationLibrary` struct documentation.
Can we push this over the line @robbkidd , or is some synchronization required?
Good to merge once the conflict is resolved.
https://github.com/open-telemetry/opentelemetry-ruby/blob/a1b57a747341831508166e3dd6dcce5a1a7e48d1/sdk/lib/opentelemetry/sdk/trace/config/trace_config.rb#L49 and https://github.com/open-telemetry/opentelemetry-ruby/blob/a1b57a747341831508166e3dd6dcce5a1a7e48d1/sdk/lib/opentelemetry/sdk/trace/tracer_provider.rb#L15 So something like: ```ruby sampler = OpenTelemetry::SDK::Trace::Samplers.parent_or_else(OpenTelemetry::SDK::Trace::Samplers.probability(0.001)) trace_config = OpenTelemetry::SDK::Trace::Config::TraceConfig.new(sampler: sampler) OpenTelemetry.tracer_provider.active_trace_config = trace_config ``` The heavily nested namespaces are decidedly unpleasant when you see them like...
> Thanks, what about exposing the sampler as an SDK configuration method? We can do that, but the spec also [allows the sampler to be replaced after configuration](https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/sdk.md#tracer-creation) (MAY rather...
And actually, I think we want to make the configuration even less wordy by providing helpers for the standard samplers: ```ruby OpenTelemetry::SDK.configure do |c| c.trace_sampler = c.parent_or_else(c.probability(0.001)) ... end ```
For now, the specifics of signal handling are up to application authors. We should clearly document `TracerProvider#shutdown` (rather than `flush`) and suggest its use with signal handling. The spec says...
Code coverage is evaluated as part of CI for several gems (but not all) and results are written to the filesystem, e.g. ``` Coverage report generated for Unit Tests to...
[The OTLP/HTTP part of the spec unambiguously states](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/otlp.md#failures-1) > Response body for all HTTP 4xx and HTTP 5xx responses MUST be a Protobuf-encoded [Status](https://godoc.org/google.golang.org/genproto/googleapis/rpc/status#Status) message that describes the problem. Originally,...