fbmal7

Results 13 comments of fbmal7

Is there a particular reason you need to use `getCallStackNoAlloc`? Otherwise this is quite simple to get the error string using JSI. ``` // Grab "Error" from the global namespace...

I'm still not sure I understand why you need to use `getCallStackNoAlloc`. Either way, this seems to be a question more so about RN, not Hermes. Hermes has no concept...

Hi @scarlac, just wanted to update you that the team has started an investigation into this issue. We are optimistic that we can bring perf improvements to JSON.parse, to bring...

@scarlac We just landed [40de6b5](https://github.com/facebook/hermes/commit/40de6b54636eee41c3a0f347f9144f5b94e42a5e) which did bring a decent perf win. When I ran it locally against the benchmark you provided, it improved the speed by 33%. We still...

We don't tend to cut releases for Hermes very often. Building Hermes from source is always an option, and it's not too complicated. If you just want to build hermes...

Hi @scarlac, just wanted to update you again. To get better improvements past the simple one we already landed has been a lot more work than initially anticipated. However, I...

@scarlac My favorite thread to update! I'm finally getting around to landing some of the changes I wrote a couple months back. Two optimizations just landed yesterday and will make...

@hakansaglam29 We can't debug the issue until you provide working repro steps. You should also open a new issue as this doesn't have to do with JSON parsing performance. There...

[Here](https://github.com/facebook/hermes/commit/a26472fb0c19b4774671b795c48f01f40273152d) is a recent change to our date parsing that may help you find some relevant locations in the codebase.

I would urge you to think through all of the edge cases when it comes to this kind of format as well. And then put them into tests once you...