Florian Bender

Results 45 comments of Florian Bender

I'd be interested in this as well. Support for 2.x may end this year.

Sorry for dragging my feet on this, a couple of things came up and had to focus somewhere else. Thanks for taking care of the issues. I intend to revisit...

I think one other aspect, also in light of a security audit, is to minimize the footprint of the code, both in terms of LoC and external dependencies. Two things...

Yeah, either have an immutable object / dictionary, or have a getter that returns an instance of `Map`. I'm not sure however if there is any sensible use case where...

A getter makes it clear that the data tied to the port itself is immutable (by returning a copy of the internal Map), so you can never change it globally....

@marcoscaceres if you return a Map via getter, the Map does not need to be frozen – that's why I'd use a getter, to actually let it return a standard...

That's the idea behind returning a copy via the getter: It does not matter if the Map gets edited. You always get the "fresh" copy from the getter, and if...

You already said that, BTW: > What might also work is having a .getInfo() method that returns an ES6 map of the metadata. That way, you always get a fresh...

:+1: Simple and efficient.

In addition to emitting a warning through `pip`, I'd make sure the Warehouse shows a big banner with a deprecation notice and in that banner link to a potential successor...