Felix Boehm

Results 106 comments of Felix Boehm

Interesting issue. cheerio's `prop` also accesses attributes by default, which is non-standard. I quite like the way `prop` works in Cheerio at the moment, and will have to think about...

I'm unfortunately unable to reproduce this. Happy to revisit this issue should I receive HTML that breaks the parser (does not need to be reduced, I'm happy to do this...

This was just merged and a new release hasn't been issued yet. I'm working through my list for remaining changes, so this hopefully won't take long.

@christo https://github.com/cheeriojs/cheerio/blob/main/src/api/extract.ts

You must either be using an old version of htmlparser2, or have xmlMode enabled. Current versions of the module will skip over `

@tatomyr Please have a look! Tests are green, please let me know if anything else needs to happen to get this over the finish line.

Thanks for the review, addressed all comments! > And one more thing. Whatever changes here should also apply to the corresponding rule [no-unused-components](https://github.com/Redocly/redocly-cli/blob/main/packages/core/src/rules/oas3/no-unused-components.ts). Do you mean introducing the additional data...

> WIth the latest changes it doesn't seem to remove transitive references anymore 😅 Tests are passing, and the codebase I am looking at (~1000 auto-generated components with ~20% unused)...

@tatomyr Anything I can help with to make this move forward?

Realised there was a comment I had not addressed, just did so!