Felix Boehm

Results 106 comments of Felix Boehm

The current set of exports is guided by what's needed by the other parse5 packages. They always use generic adapters, with the default adapter being the, well, default. I'm down...

TypeScript enums are [exported as JS objects](https://www.typescriptlang.org/play?#code/KYOwrgtgBAYg9nKBvAUFKAhAhgJwDRqZYBeKAvkA). Eg. `NodeType.Document` will also work in plain JS.

True, the enums currently aren't exported. One workaround for now is to call the adapter methods for creating nodes, but (as said before) I'm not opposed to exporting everything that's...

Not opposed to making this a string union 👍

The default tree adapter is in the package exports, no need for a deep import. I am not sure what this issue is about specifically, it seems like several of...

> Enums are hard to use, particularly for `NS` and such I can see that. We can transition more of these to string types as there is a need. >...

Thanks for flagging! For starters, it is unfortunate that this wasn't caught earlier. The CI should cover the oldest supported Node version, which it didn't do here. Sorry about that!...

> rc releases should've probably be published with --tag=next Agreed. Unfortunately, changing this now will leave people stuck on one of the older RCs, as well as promote an old...

> In the meantime, try/catch requiring of the updated deps, and falling back to htmlparser2, seems like it would fix the bugs for modern engines while restoring rc3 behavior for...

> `cheerio-select-tmp` has a peerDep on `@types/node@^14.11.2` Whee, good catch. This isn't actually used, I've removed it in https://github.com/cheeriojs/cheerio-select/commit/9e002c64119e6e8d0a200b3e7ccda5fb6bef9a84