dash_chat icon indicating copy to clipboard operation
dash_chat copied to clipboard

[Question] Why is it necessary for scrollNotificationFunc to always return true?

Open lisamartin00 opened this issue 4 years ago • 0 comments

Based on our debugging this morning, our team believes we cannot wrap DashChat with RefreshIndicator because scrollNotificationFunc returns true for the NotificationListener's onNotification. This essentially suppresses scroll events and prevents them from bubbling up.

We are currently on a fork and can flip this to false for our own needs, but I'm curious:

  1. Why does this return true in the first place? It looks like it's related to adding the ScrollToBottom widget functionality: https://github.com/fayeed/dash_chat/commit/91f4eeb789a33a1647a9696be873a0103d1be5c9
  2. Are there implications to flipping this to false that our team has not anticipated? https://github.com/fayeed/dash_chat/blob/cfbc9036c3a85996fa0f18c16930b7706ff94ccd/lib/src/message_listview.dart#L99

Thanks so much for your time and help!

lisamartin00 avatar May 28 '21 20:05 lisamartin00